Don't continue processing on client error#20
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prevents client errors (4xx responses except 429) from being retried by introducing a new ClientError type that signals non-retryable failures. When such errors occur, the event is not requeued for processing.
Changes:
- Introduced a
ClientErrortype to wrap non-retryable client errors - Modified error handling to return
ClientErrorfor 4xx responses (except 429) - Updated the controller to check for
ClientErrorand return early without requeuing
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/deploymentrecord/client.go | Added ClientError type and updated PostOne to return it for client errors |
| internal/controller/controller.go | Added error handling to detect ClientError and prevent requeuing |
| Dockerfile | Updated golang base image SHA256 hash |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
malancas
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a client error such as 404 is returned, make sure the event is not added back to the work queue.